String and Byte[] are special-cases since they are built in types tha… #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t C# sees as enumerable. They should not be unbounded in the wsdl since that would cause clients to generate byte[] as byte[][] etc. fixes DigDes#959
…hub.com/andersjonsson/SoapCore into fix-wsdl-error-for-string-and-bytearray
…Name"-property of XmlElementAttribute was not used as name in the wsdl. Unclear if this change will cause havoc
vidrenning
added a commit
to vidrenning/SoapCore
that referenced
this pull request
Jan 30, 2024
This is a regression of DigDes#960. In commit 5026da3, the AddSchemaType() method was changed to contain a special case for string and byte[]. However this breaks the situation where the inner type of a list is string. In that case, maxOccurs must be set to "unbounded" for the string element. So this commit reverts that change and instead fixes the original issue at another place. Fixes DigDes#988
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t C# sees as enumerable. They should not be unbounded in the wsdl since that would cause clients to generate byte[] as byte[][] etc.
fixes #959
Also added support for ElementName-property of XmlElementAttribute. There are lots of scenarios around this attribute that are still not supported