Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chainTxData for 8.22.0 #140

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Update chainTxData for 8.22.0 #140

merged 1 commit into from
Oct 26, 2023

Conversation

cdonnachie
Copy link

Correct incorrect entry for chainTxData in Mainnet and Testnet

  • Block 17700000 for mainnet
  • Block 2385000 for testnet

Fix #139

@gto90 gto90 added the bug Something isn't working label Aug 27, 2023
gto90
gto90 approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@ycagel
Copy link
Member

ycagel commented Oct 3, 2023 •
edited
Loading

Thanks for taking the time to review @gto90! Any feedback @JaredTate, @digicontributer or @SmartArray?

@saltedlolly
Copy link

saltedlolly commented Oct 10, 2023 •
edited
Loading

I have been running this for over a month on a Raspberry Pi 4 8GB. It completely solves issue #139.

@SmartArray @digicontributer @JaredTate Could you please help by reviewing this? It would be great to get this merged so we can release RC3.

@ycagel
Copy link
Member

ycagel commented Oct 10, 2023 •
edited
Loading

Be great to have someone test this from the source branch on Windows & Mac and report their findings.

@ghost
Copy link

ghost commented Oct 11, 2023

26 seconds to load. Normally more than 24 hours. On testnet. Build with pr #140 && pr #142

IMG_0074.mov

@ycagel
Copy link
Member

ycagel commented Oct 11, 2023

We need testing on Mac.

@j50ng j50ng mentioned this pull request Oct 12, 2023
Merged
j50ng
j50ng approved these changes Oct 12, 2023
View reviewed changes
Copy link

@j50ng j50ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK (tested but not reviewed)

See comment here #142 (review)

JaredTate
JaredTate approved these changes Oct 26, 2023
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Looks straightforward, thanks for working on this and all your help with $DGB!

@gto90 gto90 merged commit 5d912a9 into DigiByte-Core:develop Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredTate JaredTate JaredTate approved these changes

@gto90 gto90 gto90 approved these changes

@j50ng j50ng j50ng approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@ycagel ycagel Awaiting requested review from ycagel

@digicontributer digicontributer Awaiting requested review from digicontributer

@Sbosvk Sbosvk Awaiting requested review from Sbosvk

Assignees

@cdonnachie cdonnachie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync issues running DigiByte Core 8.22.0-rc2 mainnet on Raspberry Pi 4 8Gb
6 participants
@cdonnachie @ycagel @saltedlolly @JaredTate @gto90 @j50ng