Fix issue 255: implement patches for pre-release channels #310

dennisvang · 2021-12-06T16:23:24Z

This is an attempt to fix the implementation of patches for pre-release channels, as discussed in issue #255 .

…nnel (instead of just stable)

catch FileNotFoundError, due to missing manifest, in utils.make_archive()

add test for utils.make_archive(), reproducing issue 304

fix Package.name_regex

introduce a parse_archive_name function, with tests

use parse_archive_name to fix Package.extract_info removed Package._parse_package_name, now unused

cherry-pick VALID_CHANNELS from bce7d36 (issue311)

introduce a gen_pep440_version(), similar to gen_user_friendly_version, with tests

refactor gen_pep440_version to handle stable (post) release versions

refactor get_highest_version() to use gen_pep440_version()

add test to verify packaging.version.parse() compatibility of gen_pep440_version output

remove redundant f-string specifiers

add test to show that alpha/beta patches are not applied

remove channel==stable condition for patch update

add test to show that Patcher.__init__ messes up the current version.

move command line version check from utils.builder to cli.options and use packaging.version, with tests

add some typing for version string arguments, to prevent confusion

Merge branch 'issue299' into drop-dsdev-version

implement Package.channel as property, using packaging Version instead of dsdev-utils Version

fix cli app_version test

move VALID_CHANNELS from cli.options to settings, to prevent circular imports (and it's more obvious)

assign parts only after checking for TypeError, and fix Package tests

add todo notes for next release (backward incompatible changes)

remove parse_platform, as it has been replaced by parse_archive_name

rename PackageHandler private methods for consistency

add a LATEST_KEY for consistency

create a VersionShim class in utils, replacing the version functions from client.updates

adapt TestLibUpdate to use new version_manifest test fixture

add test for Patcher._get_required_patches

simplify fall_back return value for Patcher._get_patch_info()

remove redundant name arg from Patcher._get_required_patches

add tests for Patcher._get_patch_info()

remove args name and option from Patcher._get_info() and simplify (only option=file is ever used)

clean up test_patcher (DRY patcher kwargs)

remove unnecessary usefixtures from test_client

rename PackageHandler._load_version_file to _load_version_data, because it does not load a file

remove PackageHandler._add_package_to_config, as it does not seem to serve any purpose

untangle config arguments from PyUpdater, PackageHandler, Uploader, and PluginManager, and amend tests

clean up package handler tests

rename variables in Package.extract_info, for consistency

remove all usage of py_repo_config from PackageHandler

remove all usage of py_repo_config from Patch, let patch filename match archive filename, except suffix

move get_latest_version from client to utils, and amend tests

Merge branch 'issue255' into issue323

remove strict arg from get_latest_version, Client.update_check, and LibUpdate (use channel=None instead of strict=True), amend tests

remove usage of 'latest' manifest object from Patch, use get_latest_version instead

remove unused _channel from Patch

remove Patch.channel, remove _test condition from Patch, improve test coverage for Patch

remove Package.channel property, and amend tests

remove last usage of 'latest' manifest object from PackageHandler, todo: create cli tool to create legacy versions.gz

rename Patch._pkg_info to _new_pkg for consistency

add None to VALID_CHANNELS

remove last remaining channel attributes

rename Client obj arg to client_config, for clarity

dennisvang added 15 commits December 6, 2021 17:11

raise IOError when trying to decompress None

cefbed6

update note in client-advanced docs: patches are created for each cha…

0bd665c

…nnel (instead of just stable)

issue304:

328cc8c

catch FileNotFoundError, due to missing manifest, in utils.make_archive()

issue304:

d1a05e2

add test for utils.make_archive(), reproducing issue 304

issue299:

794c47f

fix Package.name_regex

issue299:

6233d78

introduce a parse_archive_name function, with tests

issue299:

7809fac

use parse_archive_name to fix Package.extract_info removed Package._parse_package_name, now unused

issue315:

013d0cb

cherry-pick VALID_CHANNELS from bce7d36 (issue311)

issue315:

0e7e7bf

introduce a gen_pep440_version(), similar to gen_user_friendly_version, with tests

issue315:

d3f3983

refactor gen_pep440_version to handle stable (post) release versions

issue315:

65c5d92

refactor get_highest_version() to use gen_pep440_version()

issue315:

4df91db

add test to verify packaging.version.parse() compatibility of gen_pep440_version output

issue315:

414a97e

remove redundant f-string specifiers

issue255:

9f7ecac

add test to show that alpha/beta patches are not applied

issue255:

af1493f

remove channel==stable condition for patch update

dennisvang marked this pull request as draft December 22, 2021 19:56

dennisvang changed the title ~~update note in client-advanced docs: patches are created for each channel~~ apply patches for pre-release channels Dec 22, 2021

dennisvang added 13 commits December 22, 2021 22:15

issue315:

fe3bad6

add test to show that Patcher.__init__ messes up the current version.

drop-dsdev-version:

75e2294

move command line version check from utils.builder to cli.options and use packaging.version, with tests

drop-dsdev-version:

fda57e2

add some typing for version string arguments, to prevent confusion

drop-dsdev-version:

7663f16

Merge branch 'issue299' into drop-dsdev-version

drop-dsdev-version:

961cb79

implement Package.channel as property, using packaging Version instead of dsdev-utils Version

drop-dsdev-version:

e26985d

fix cli app_version test

drop-dsdev-version:

4c196e5

move VALID_CHANNELS from cli.options to settings, to prevent circular imports (and it's more obvious)

drop-dsdev-version:

de36b58

assign parts only after checking for TypeError, and fix Package tests

drop-dsdev-version:

0fc92a6

add todo notes for next release (backward incompatible changes)

drop-dsdev-version:

47dbd29

remove parse_platform, as it has been replaced by parse_archive_name

drop-dsdev-version:

c830bc9

rename PackageHandler private methods for consistency

drop-dsdev-version:

e6470df

add a LATEST_KEY for consistency

drop-dsdev-version:

e7ad90e

create a VersionShim class in utils, replacing the version functions from client.updates

dennisvang added 8 commits January 5, 2022 23:33

issue255:

0bb41df

adapt TestLibUpdate to use new version_manifest test fixture

issue255:

985da70

add test for Patcher._get_required_patches

issue255:

2923b6c

simplify fall_back return value for Patcher._get_patch_info()

issue255:

18c0008

remove redundant name arg from Patcher._get_required_patches

issue255:

52c2d45

add tests for Patcher._get_patch_info()

issue255:

96d7899

remove args name and option from Patcher._get_info() and simplify (only option=file is ever used)

issue255:

9dcbb94

clean up test_patcher (DRY patcher kwargs)

issue255:

b647167

remove unnecessary usefixtures from test_client

dennisvang changed the title ~~apply patches for pre-release channels~~ Fix issue 255: implement patches for pre-release channels Jan 6, 2022

dennisvang mentioned this pull request Jan 6, 2022

Patches on other channels #255

Closed

dennisvang added 19 commits January 6, 2022 16:44

issue255:

fedf5ad

rename PackageHandler._load_version_file to _load_version_data, because it does not load a file

issue323:

1f3b94f

remove PackageHandler._add_package_to_config, as it does not seem to serve any purpose

issue323:

b1ad1ce

untangle config arguments from PyUpdater, PackageHandler, Uploader, and PluginManager, and amend tests

issue323:

a492761

clean up package handler tests

issue323:

25a2475

rename variables in Package.extract_info, for consistency

issue323:

7c08f65

remove all usage of py_repo_config from PackageHandler

issue323:

b41aeb5

remove all usage of py_repo_config from Patch, let patch filename match archive filename, except suffix

issue255:

0788352

move get_latest_version from client to utils, and amend tests

issue323:

c2c2fdb

Merge branch 'issue255' into issue323

issue255:

2502930

remove strict arg from get_latest_version, Client.update_check, and LibUpdate (use channel=None instead of strict=True), amend tests

issue255:

414da2d

remove usage of 'latest' manifest object from Patch, use get_latest_version instead

issue255:

4cc0a1d

remove unused _channel from Patch

issue255:

475698d

remove Patch.channel, remove _test condition from Patch, improve test coverage for Patch

issue255:

48c915a

remove Package.channel property, and amend tests

issue255:

a298ca9

remove last usage of 'latest' manifest object from PackageHandler, todo: create cli tool to create legacy versions.gz

issue255:

4d6878a

rename Patch._pkg_info to _new_pkg for consistency

issue255:

2d6cbc6

add None to VALID_CHANNELS

issue255:

5e17f81

remove last remaining channel attributes

issue323:

f45550c

rename Client obj arg to client_config, for clarity

JMSwag closed this Sep 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue 255: implement patches for pre-release channels #310

Fix issue 255: implement patches for pre-release channels #310

dennisvang commented Dec 6, 2021 •

edited

Loading

Fix issue 255: implement patches for pre-release channels #310

Fix issue 255: implement patches for pre-release channels #310

Conversation

dennisvang commented Dec 6, 2021 • edited Loading

dennisvang commented Dec 6, 2021 •

edited

Loading