-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommendations on homepage #498
Merged
niraymak
merged 10 commits into
feature/380-redesign-homepage
from
feature/497-recommendations-homepage
Jun 2, 2021
Merged
Recommendations on homepage #498
niraymak
merged 10 commits into
feature/380-redesign-homepage
from
feature/497-recommendations-homepage
Jun 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load in when the user is authenticated and when there are 2 or more recommendations to show
Please wait with fixing this merge conflict until the homepage is merged |
…t. Conditional rendering on home page based on authentication
… also show up if there is only 1 recommendation.
….com/DigitalExcellence/dex-frontend into feature/497-recommendations-homepage
…ndations-homepage
niraymak
requested review from
RubenFricke and
waltersajtos
and removed request for
RubenFricke
June 2, 2021 08:19
waltersajtos
approved these changes
Jun 2, 2021
RubenFricke
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shows project recommendations on the new home page.
Type of change
Checklist
Steps to Test or Reproduce
If you can't run the backend in Docker I recommend to hardcode an array of projects in the recommendation service.
To test this feature you should run all backend containers except the notificationsystem and jobscheduler.
If unclear, please contact me.
Link to issue
Closes: #497