Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mobile styling to overlay #586

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

elislaats
Copy link
Contributor

@elislaats elislaats commented Oct 7, 2021

Description

Added mobile styling exceptions to the edit page where needed to get around the hover-overlay.

there's no sprint 3 board yet so I'll add this PR it it as soon as that's there + I'll add a changelog entry when the changlog has a part for the next release, as discussed with @DaveBouman 😄

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Go to DeX on mobile or create mobile in devtools
  2. Go to edit page and the images tab
  3. See the image previews
  4. Note that its now clear what will happen when you click on the icon or image-preview

Link to issue

Closes: #584

@DaveBouman
Copy link
Contributor

Added it to front end sprint 3 will review later

@elislaats elislaats requested a review from NealGeilen October 14, 2021 07:25
@NealGeilen NealGeilen merged commit b3ed872 into develop Oct 14, 2021
@NealGeilen NealGeilen deleted the bugfix/584-overlay-on-mobile branch October 14, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay doesn't work on mobile
3 participants