Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/593 nav bar spacing incorrect #594

Merged
merged 7 commits into from
Oct 22, 2021

Conversation

BartvanEijkelenburg
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Log in into Dex.
  2. check if your username responds correctly to resizing the window.

Closes: #593

NealGeilen
NealGeilen previously approved these changes Oct 20, 2021
@elislaats
Copy link
Contributor

I'll have time to look at this tomorrow!

Copy link
Contributor

@elislaats elislaats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue doesn't seem to be fixed.

When I add a long username it (still) looks like this:
image

If I understand it well, looking at the inspection tools, I think the 200px in the grid-template-columns on the .header .content could be causing this issue. The code you added seems to get overwritten by that.
image

Please let me know if I'm misunderstanding, but I think this still needs some more work 😄

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@elislaats elislaats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bettter! There is a small thing, where there's some odd whitespace at the end of the profile-block now.

image

I think there's some margin that's not needed anymore here:
Untitled

Also a small comment specific to your last change

src/app/components/app-layout/app-layout.component.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@elislaats elislaats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for fixing my remarks. Good work!

Copy link
Contributor

@HansenSven HansenSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good with the truncate as well, 👍 perhaps the search project bar on the homepage can get a minimum width but that's not something for now.

@BartvanEijkelenburg BartvanEijkelenburg merged commit 35ad1d0 into develop Oct 22, 2021
@BartvanEijkelenburg BartvanEijkelenburg deleted the bugfix/593-NavBar-Spacing-Incorrect branch October 22, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavBar spacing incorrectly when on desktop
4 participants