Issue 61 #62
Merged
Issue 61 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a few type annotations while I was at it.
|
I am not really sure of your process here (my first OS contribution (🎉 ) ) - I branched from master, but I left the PR at the default branch (develop). Could you get back to me on whether there are any formalities (or other stuff for that matter) I am missing? |
andreujuanc
requested changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #61 which I now see is a dupe of #57
Implementation is almost exclusively copied from other parts.
In my own additions (expansion of method signatures, mostly), I tried to meet the existing style.
Tests done:
I have verified functionality against several Subscriptions, but I didn't have any Queues with DLQ's to test against.