Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kereru Sifter ticket, #7295 Closing a filter (x) should refresh the search #38

Merged
merged 4 commits into from
Jul 12, 2016

Conversation

UberMouse
Copy link

@UberMouse UberMouse commented Jul 12, 2016

Acceptance Criteria

  • sifter ticket is fixed

Checklist

  • Code is understandable without Dev
  • Acceptance criteria, what was changed, and why it was changed (If applicable) on Pull / Merge Request
  • All Tests are Passing
  • Code Coverage goes up
  • All new methods have a relevant spec
  • Methods have a single responsibility (Where applicable)
  • Linters Pass
  • ‘Yard’ style comments on methods and classes (Where applicable)

This change is Reviewable

@hapiben
Copy link
Member

hapiben commented Jul 12, 2016

Test is failing. Aside from that, everything looks great to me.

@hapiben
Copy link
Member

hapiben commented Jul 12, 2016

Do you think we should have a look at this issue with Travis?

@UberMouse
Copy link
Author

UberMouse commented Jul 12, 2016

I've looked as best I can, it's hard to test Travis builds locally so I haven't gone that far but it might be worth it at some point. I've raised an issue in shakacode/react_on_rails#475

@EdwinRozario EdwinRozario merged commit 766b223 into master Jul 12, 2016
@paul-mesnilgrente paul-mesnilgrente deleted the tl/kereru-sifter branch September 9, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants