Patch 2 #142
Merged
Patch 2 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve update method of domainRecord
| if ($weight !== null) { | ||
| $content['weight'] = $weight; | ||
| } | ||
|
|
||
| return $this->updateFields($domainName, $recordId, ['name' => $name]); |
There was a problem hiding this comment.
You forgot to call the updateFields method with the $content array.
some code correction
correct
| 'port' => $port, | ||
| 'weight' => $weight | ||
| ); | ||
| $content = array_filter($content); |
There was a problem hiding this comment.
Please pass a callback function into here so that null values are filtered only, instead of just empty ones.
add callback to filter null and false values
| 'weight' => $weight | ||
| ); | ||
| $content = array_filter($content, function($val){ | ||
| return $val !== null && $val !== false; |
remove false condition and use compact function
|
LGTM. @GrahamCampbell what do you think? If everything is OK you can merge. @i0 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve domain record update function:
https://developers.digitalocean.com/documentation/v2/#update-a-domain-record