Skip to content

Commit

Permalink
removed order fetch after submission (#853)
Browse files Browse the repository at this point in the history
  • Loading branch information
vslee authored Nov 22, 2024
1 parent f4ba38a commit dad0ec7
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The above copyright notice and this permission notice shall be included in all c
using Newtonsoft.Json.Linq;
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading.Tasks;

Expand Down Expand Up @@ -450,10 +451,13 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd

try
{
JToken result = await MakeJsonRequestAsync<JToken>($"/orders", payload: payload, requestMethod: "POST" );
// The Post doesn't return with any status, just a new OrderId. To get the Order Details we have to reQuery.
return await OnGetOrderDetailsAsync(result[ORDERID].ToStringInvariant());
}
JToken jtokenResult = await MakeJsonRequestAsync<JToken>($"/orders", payload: payload, requestMethod: "POST" );
var orderResult = ParseOrder(jtokenResult["success_response"]);
Debug.Assert(jtokenResult.Value<bool>("success") == true);
// the jtokenResult doesn't have the order status inside the "success_response" portion, but rather outside of it, so need to set it manually
orderResult.Result = ExchangeAPIOrderResult.PendingOpen;
return orderResult;
}
catch (Exception ex) // All fails come back with an exception.
{
Logger.Error(ex, "Failed to place coinbase error");
Expand Down

0 comments on commit dad0ec7

Please sign in to comment.