Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change volume data type in MarketCandle #837

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

BZ-CO
Copy link
Contributor

@BZ-CO BZ-CO commented Jul 2, 2024

Change volume data type in MarketCandle from double to decimal.

Change volume data type in MarketCandle from double to decimal.
@vslee vslee merged commit 40fac2f into DigitalRuby:main Jul 2, 2024
1 of 3 checks passed
@vslee
Copy link
Collaborator

vslee commented Nov 18, 2024

@BZ-CO, I will be pushing out a new NuGet soon. Before I do so, can you take a look at the test:

MEXCAPITests.GetTickersAsyncShouldReturnTickers()

Looks like it's failing because the volume of DTUSDT is 136651248485429227479402823307.68, which overflows decimal. Now we didn't even have MEXC support until you added it, so I'm going to defer to you on this one. Would you like to keep this change to decimal (which I'm fine with), or rollback?

{{ "symbol": "DTUSDT", "priceChange": "-0.000000000000000000000001", "priceChangePercent": "-0.25", "prevClosePrice": "0.000000000000000000000004", "lastPrice": "0.000000000000000000000003", "bidPrice": "0.000000000000000000000002", "bidQty": "674761418857801392904627655.1", "askPrice": "0.000000000000000000000003", "askQty": "218152129484027038417612334.96", "openPrice": "0.000000000000000000000004", "highPrice": "0.000000000000000000000019", "lowPrice": "0.000000000000000000000002", "volume": "136651248485429227479402823307.68", "quoteVolume": "557005.162690709267440406353736", "openTime": 1731956703065, "closeTime": 1731956770502, "count": null }}

@BZ-CO
Copy link
Contributor Author

BZ-CO commented Nov 18, 2024

@vslee, I've tested the other exchanges, and everything seems ok there. There are only a few pairs with such high volume on MEXC and we will just exclude them. Will send a fix now.

@BZ-CO BZ-CO mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are we using double for BaseCurrencyVolume and QuoteCurrencyVolume in MarketCandle?
2 participants