-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcut to start/stop drawing annotation #154
Conversation
@manthey coverage is failing - do you usually have tests for things like keyboard shortcuts? |
This starts drawing a line. Were you thinking of adding additional keyboard bindings for the other shapes? Or should we have a concept of a recent shape and choose that? And, if so, then we might want another key to cycle through the shapes. |
We do test some keyboard shortcuts (e.g., https://github.com/DigitalSlideArchive/HistomicsUI/blob/master/tests/web_client_specs/annotationSpec.js#L327). |
Additional keyboard bindings for each shape would be easiest to implement code-wise and UX-wise, I think. (just adding keyboard shortcuts to each of the shapes' tooltips seems easier than trying to communicate what the recent shape is to the user). I'll try that.
Thanks, I'll take a look at those and write some tests for the new shortcuts. |
I think using letters that are somehow associated with the shape will be more memorable than using the top right six letters (but I'm willing to be argued out of it). Maybe: |
I don't have a strong preference, but I can see it being easier to remember if they are associated with a letter. I'll change it to those |
894c331
to
e88dec8
Compare
I added tests for the new shortcuts. Looks like CI is happy with coverage now. |
e88dec8
to
5277693
Compare
5277693
to
cd57963
Compare
48e72b4
to
4aa765d
Compare
Pressing
n
willFixes in part #145