Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brush controls #184

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add brush controls #184

merged 1 commit into from
Jun 28, 2022

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jun 28, 2022

Closes #147.

Closes #141. The current style group and brush settings are stored in local storage.

Currently, circle and ellipse annotations are converted to polygons when they are combined in some manner. This could be done in a coarser manner to reduce the number of vertices. The current setting is no more than 1/10th of a pixel of error at the maximum zoom level (typically this is twice the resolution of the base image, so 1/20th of a base image pixel, though that can be increased). Perhaps something like 1/2 of a base pixel would be sufficient and speed up some of the processes.

Also, this currently becomes slow with a large number of annotation elements because it updates the entire annotation feature. To speed this up, we probably would need to render the annotation as two sets of features (unchanged and recently changed), but that would involve more book-keeping. Once this is in use, we'll see where the limit of performance is located and adjust accordingly.

@manthey
Copy link
Contributor Author

manthey commented Jun 28, 2022

This needs to add keyboard and control documentation, but that will be done in a subsequent PR. 'b' switches to brush mode. 'B' cycles through brush shapes. 'z' and 'x' change brush size.

@manthey manthey merged commit 4388492 into master Jun 28, 2022
@manthey manthey deleted the brush branch June 28, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation paint brush Changing tabs switches to default style group
1 participant