Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes update to version 3.0 of flutter. #147

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

UP929312
Copy link
Contributor

This change will fix the error when using Flutter 3.0,

: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
../…/lib/grouped_list.dart:264

  • 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance!.addPostFrameCallback((_) {

@Dimibe Dimibe merged commit 910e08f into Dimibe:main May 16, 2022
@UP929312 UP929312 deleted the patch-1 branch May 17, 2022 14:02
@ekuleshov
Copy link

@Dimibe unfortunately this fix make the last version of this package only compatible with Flutter 3, yet package sdk restrictions are at the level supported with Flutter 2.

It would be really nice if package supported both Flutter 2 and 3

To preserve backward compatibility with Flutter 2 the recommended way is to use this approach https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0#your-code

For example:
jonataslaw/getx@9d2b872

@Dimibe
Copy link
Owner

Dimibe commented May 20, 2022

Hi @ekuleshov,
I will look into it. For the moment, just use the latest 4.x version of the grouped_list package if you are using Flutter 2

@Dimibe
Copy link
Owner

Dimibe commented May 28, 2022

@ekuleshov Fixed in version 5.1.0

@ekuleshov-idexx
Copy link

Thank you!

@ekuleshov
Copy link

Spoke too soon. The package sdk requirement is still left at >=2.17.0 <3.0.0
To support Flutter 2 the dart sdk version need to be up to 2.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants