fix: force light content status bar #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason kept reverting to dark text which looked not good
Before, the Category rows could only be tapped by tapping on the text in the cell. This convert the category cell to a button so the entire row is tappable. It should look the same.
so you don't blind yourself opening this at night / smoother transition
- When sort is activated the Navigation Bar Item will become filled. - Changed "Remove Filter" copy to "Clear Selection" since its not really a filter. - Localized Capitalized should be the preferred capitalization method since it will take in to account use locale. - The action sheet will now show what the currently selected sort is.
before, things looked squashed- now they aren't!
When running in split screen, the colors looked off. This adds a placeholder view.
Just an empty screen, this gives the user some instruction
This PR aims to add nookazon integrations for items!
|
Oops. It appears this is my master branch. |
rohanrk
pushed a commit
to rohanrk/ACHNBrowserUI
that referenced
this pull request
Jun 15, 2020
sync with master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for some reason kept reverting to dark text which looked not so good.
Screenshot(s)