added linux support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makefile and desktop-file modified to install linux icon. it requires image-magick to scale the image. This should work on the most common linux desktops.
DinkDonk
reviewed
Aug 25, 2024
| xdg-icon-resource install --size 512 kitty-light-512.png custom-kitty-icon | ||
| cp kitty.desktop ~/.local/share/applications/kitty.desktop | ||
|
|
||
|
|
| @@ -1,3 +1,17 @@ | |||
| all: | |||
| npx png2icons kitty-light.png kitty-light -icns && npx png2icons kitty-dark.png kitty-dark -icns | |||
|
|
|||
| install-light-icon: | |||
There was a problem hiding this comment.
Rename to linux-install-light-icon
| cp kitty.desktop ~/.local/share/applications/kitty.desktop | ||
|
|
||
|
|
||
| install-dark-icon: |
There was a problem hiding this comment.
Rename to linux-install-dark-icon
| xdg-icon-resource install --size 512 kitty-dark-512.png custom-kitty-icon | ||
| cp kitty.desktop ~/.local/share/applications/kitty.desktop | ||
|
|
||
| uninstall-icon: |
|
|
||
| install-dark-icon: | ||
| magick kitty-dark.png -resize 512x512 kitty-dark-512.png | ||
| xdg-icon-resource install --size 512 kitty-dark-512.png custom-kitty-icon |
There was a problem hiding this comment.
Is xdg-icon-resource a common utility across Linux distros with different desktop environments?
| @@ -18,6 +20,27 @@ An alternative MacOS application icon for the wonderful [Kitty](https://sw.kovid | |||
| $ rm /var/folders/*/*/*/com.apple.dock.iconcache; killall Dock | |||
| ``` | |||
|
|
|||
| #### Linux | |||
|
|
|||
| 1. clone this repo | |||
| 2. Makefile should work with the most common Desktops | ||
|
|
||
| ```bash | ||
| make install-dark-icon |
There was a problem hiding this comment.
Rename to linux-install-dark-icon
| ``` | ||
| or | ||
| ```bash | ||
| make install-light-icon |
There was a problem hiding this comment.
Rename to linux-install-light-icon
| use | ||
|
|
||
| ```bash | ||
| make uninstall-icon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makefile and desktop-file modified to install linux icon.
it requires image-magick to scale the image. This should work on the most common linux desktops.