-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to Gladiatus-Tools while forging #212
Comments
blind : could not reproduce ... I made some yolo changes
Now this is interesting, when the page gets refreshed, it keeps redirecting me to the item in slot 2 at Smelter, even when it's not selected. When I manually select another slot, it works just fine. So maybe there is a problem when the page is loaded, it seems like slot 2 URL is default for the URL link of any item that is currently selected. Same problem goes for Forge as well. If you understand me, it's easy to reproduce. |
These tabs are handled by Gameforge's code... |
Hmmm, so this one is... won't fix? |
Low priority. |
Oh, I shouldn't start this "priority" thing, now Gram is everywhere gonna write "low priority" 😆 . |
That is a low priority. |
Because of the late loading of the item data, the addon was creating the link to the item before the correct data were supplied. This was both on forge and smelt. It was fixed by checking if the existing link url is correct. |
You right, and it seems to be fixed, well done! |
During forge (or smelting) the generated item link to Gladiatus-Tools doesn't include correct prefix and suffix values.
The text was updated successfully, but these errors were encountered: