Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Gladiatus-Tools while forging #212

Closed
GreatApo opened this issue Aug 21, 2020 · 8 comments
Closed

Link to Gladiatus-Tools while forging #212

GreatApo opened this issue Aug 21, 2020 · 8 comments

Comments

@GreatApo
Copy link
Member

During forge (or smelting) the generated item link to Gladiatus-Tools doesn't include correct prefix and suffix values.

image

GramThanos added a commit that referenced this issue Aug 21, 2020
blind : could not reproduce ... I made some yolo changes
@FrutyX
Copy link
Collaborator

FrutyX commented Oct 29, 2021

Now this is interesting, when the page gets refreshed, it keeps redirecting me to the item in slot 2 at Smelter, even when it's not selected. When I manually select another slot, it works just fine.

So maybe there is a problem when the page is loaded, it seems like slot 2 URL is default for the URL link of any item that is currently selected.

Same problem goes for Forge as well.

If you understand me, it's easy to reproduce.

@GreatApo
Copy link
Member Author

Now this is interesting, when the page gets refreshed, it keeps redirecting me to the item in slot 2 at Smelter, even when it's not selected. When I manually select another slot, it works just fine.

So maybe there is a problem when the page is loaded, it seems like slot 2 URL is default for the URL link of any item that is currently selected.

Same problem goes for Forge as well.

If you understand me, it's easy to reproduce.

These tabs are handled by Gameforge's code...

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 22, 2021

Hmmm, so this one is... won't fix?

@GramThanos
Copy link
Member

Low priority.

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 22, 2021

Oh, I shouldn't start this "priority" thing, now Gram is everywhere gonna write "low priority" 😆 .

@GramThanos
Copy link
Member

Oh, I shouldn't start this "priority" thing, now Gram is everywhere gonna write "low priority" 😆 .

That is a low priority.

@GreatApo
Copy link
Member Author

GreatApo commented Dec 24, 2021

Because of the late loading of the item data, the addon was creating the link to the item before the correct data were supplied. This was both on forge and smelt. It was fixed by checking if the existing link url is correct.

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 24, 2021

You right, and it seems to be fixed, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants