Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages - last page load #258

Closed
FrutyX opened this issue Apr 9, 2021 · 6 comments
Closed

Packages - last page load #258

FrutyX opened this issue Apr 9, 2021 · 6 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Apr 9, 2021

Chrome,
v4.3.5.

v4.3.4
BUG FIXES

Packages

  • Fixed not parsing last page upon auto load

I thought this was fixed, but it wasn't, it happened to me already multiple times when I was selling my packages stuff.

For the bug description, for example, you go and search for specific items in your packages (filter them), and you move them to your inventory, but when you reach the end, the last page isn't loaded well and isn't recognized by the addon, which means no colors, no double-clicking, no anything from the addon features.

@GramThanos
Copy link
Member

=.= that bug just don't want to die

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 10, 2021

I went to test it to check if this is still a problem and I have some fresh results.

It is happening, but I didn't seen it for a long time, it is since I set my maximum loaded pages limit in packages to 10, I had only 3 max before, this time I set it only to 1 and the problem instantly occurred.

So it seems having a small number of loaded pages in packages is triggering this.

As you can see here, the last page was loaded and the last items are not recognized by GCA:

Last

Tested on:
Chrome Canary 95.0.4636.3
GCA v4.3.5

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 16, 2021

You probably won't go away with this so easily :D. It seems they are recognized that they have their colors, but I cannot double-click them, they just won't move, only the normal way works.

@GramThanos
Copy link
Member

I forgot to correct line 795...

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 17, 2021

Well, I think this time you finally fixed it, no problem found, congratulations! :D

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 8, 2021

On the list with #294.

Fixed, closing, re-open if needed.

@FrutyX FrutyX closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants