Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources tooltips - Missing items #263

Closed
GreatApo opened this issue Apr 16, 2021 · 7 comments
Closed

Resources tooltips - Missing items #263

GreatApo opened this issue Apr 16, 2021 · 7 comments

Comments

@GreatApo
Copy link
Member

GreatApo commented Apr 16, 2021

image

Sources are not shown

@GreatApo
Copy link
Member Author

GreatApo commented Apr 16, 2021

The bug only happens when resources style is 'minimal-amounts' or 'extended-amounts'. This callback never replies. I don't know how to debug the background page, so @GramThanos have fun.

@PatrykLeczycki
Copy link

The bug only happens when resources style is 'minimal-amounts' or 'extended-amounts'. This callback never replies. I don't know how to debug the background page, so @GramThanos have fun.

I'm not sure what are these resources styles you referred to, but as I see the bug happens when given item doesn't have sufix. On my level I can't find items without prefixes on auctions, but maybe someone could confirm if the same problem happens when an item doesn't have prefix but it has only sufix.

@GreatApo
Copy link
Member Author

The bug only happens when resources style is 'minimal-amounts' or 'extended-amounts'. This callback never replies. I don't know how to debug the background page, so @GramThanos have fun.

I'm not sure what are these resources styles you referred to, but as I see the bug happens when given item doesn't have sufix. On my level I can't find items without prefixes on auctions, but maybe someone could confirm if the same problem happens when an item doesn't have prefix but it has only sufix.

Not exactly. This item bellow doesn't have a suffix:
image

However, you may visually not see a suffix, but there are suffixes without names... That may be related to the problem.

PS. Resources styles are the different ways you can display the resources at the tooltips.

@PatrykLeczycki
Copy link

The bug only happens when resources style is 'minimal-amounts' or 'extended-amounts'. This callback never replies. I don't know how to debug the background page, so @GramThanos have fun.

I'm not sure what are these resources styles you referred to, but as I see the bug happens when given item doesn't have sufix. On my level I can't find items without prefixes on auctions, but maybe someone could confirm if the same problem happens when an item doesn't have prefix but it has only sufix.

Not exactly. This item bellow doesn't have a suffix:
image

However, you may visually not see a suffix, but there are suffixes without names... That may be related to the problem.

PS. Resources styles are the different ways you can display the resources at the tooltips.

You're right, I found some items without visible sufixes and tried to analyze their levels. It seems that when item's level suggest that it has any of +1 to +10 sufix, resources are visible, but the're not visible when level indicates that there's definitely no sufix. As you wrote at the beginning, some display options partially solve this problem, but they don't show amount of resources, so it's not a good solution in my case.

@GreatApo
Copy link
Member Author

As you wrote at the beginning, some display options partially solve this problem, but they don't show amount of resources, so it's not a good solution in my case.

I didn't said it is a solution, I traced where the issue is in the code. I just couldn't investigate further because the error is coming from a script running in browser's background (because the resources data are just to big in size to load them with each refresh) which I don't know how to debug (DarkThanos will investigate it). I pointed out that the other styles work to highlight that the resources count code it probably the problem. Without even looking the code, I suspect that the suffix is not contributing to the resources and in the data list is either commented or has a value of -1, which could lead to an error thrown in the background page and not in the Gladiatus webpage console ;)

I hope its clear now :)

@PatrykLeczycki
Copy link

PatrykLeczycki commented Apr 22, 2021

As you wrote at the beginning, some display options partially solve this problem, but they don't show amount of resources, so it's not a good solution in my case.

I didn't said it is a solution, I traced where the issue is in the code. I just couldn't investigate further because the error is coming from a script running in browser's background (because the resources data are just to big in size to load them with each refresh) which I don't know how to debug (DarkThanos will investigate it). I pointed out that the other styles work to highlight that the resources count code it probably the problem. Without even looking the code, I suspect that the suffix is not contributing to the resources and in the data list is either commented or has a value of -1, which could lead to an error thrown in the background page and not in the Gladiatus webpage console ;)

I hope its clear now :)

Of course, thanks for explanation :) I hope it won't be hard to fix if you'll decide to give it a try.

GramThanos added a commit that referenced this issue Sep 8, 2021
@GramThanos GramThanos removed their assignment Sep 8, 2021
@FrutyX
Copy link
Collaborator

FrutyX commented Dec 14, 2021

Guess this was fixed, re-open if not, already on the list.

Closing.

@FrutyX FrutyX closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants