-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest item reward info #265
Comments
A green from me, looking good! |
Add item name too |
No, I think it wasn't scripted, only suggested. |
Ooops, i understand that was a script =) |
God be with us. It ain't perfect, I know. |
Maybe if Apo is lurking, he can tweak it so the css is applied only on quests with an item, probably... I am not sure. |
Or you think it's fine like this? I mean, I wouldn't say it's a big deal, if it's empty, then well... no item reward, lol. |
There is a reason, why it's not there, you know how long the item names are? You should know that, when Greek got a very long words, there was no way I could fit the names in there. |
I have only the prefix presented, not the rest of the name :) (the whole name doesn't fit in the UI and it is not scalable) |
You could potentially show only the prefix/suffix (if that is possible) but that sounds more like a downgrade honestly. |
It partially is but I don't see how this can nicely fit in the UI (that black line there is because the bg image doesn't scale) |
Well, another approach would be to create a completely new element under it, basically the same like now but nice (with it's own design), but that will require rewriting the code, most of it, I guess. |
With some logic, I suppose people hunt for prefixes and suffixes, so yes, you could do that, but I seriously leave that only to you, because I already had some hiccups with this already, and the outcome isn't perfect, as you can see. |
At first, I was playing with it a lot, because I didn't wanted to add it to a new line, but like I said, there is no way you can fit the full name there, even with some css edits, it was just bad. And I didn't get any other ideas, because you do this to get rid of the hover effect, that's the point, so your options are very limited. |
Look, if you like it more, implement it. But again, people want to see it, so they don't have to hover over the image, if you cut it and add a mouse over, how different will that be from hovering over the image? It really depends on the language, some names will be alright, some, like Greek, will be with a hidden overflow. But I guess it's better than my implementation. |
I think it is a nice and neat solution that doesn't interfere a lot with the UI and it will work most of the time :) |
Yes, the idea and implementation isn't difficult, placing it in the UI layout, that's a damn mystery. |
Actually, it does, if you do some css changes, you could move the time, if it will not collide with the upper text. |
Yeah, that's actually pretty good, and I doubt any language text will touch that, not even Greek seems to be that long (lol). |
In the end you'll rewrite the whole layout lmao, that's something I was trying to avoid, but sometimes there is no choice. |
lol, well, now that is a solution too... Yeah, that's good as well. |
Nice! Good job! |
No, you good job! :D At last, I think some people will appreciate this feature. Two heads are better than one. |
Always! |
I think it would be nice to have some info about value of quest reward items, maybe somewhere in this area:
During events with -50% cooldown for quests it would be much faster to accept quests with rings/amulets as reward by just looking on some numbers rather than pointing at every single reward item.
The text was updated successfully, but these errors were encountered: