Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest item reward info #265

Closed
PatrykLeczycki opened this issue Apr 22, 2021 · 37 comments
Closed

Quest item reward info #265

PatrykLeczycki opened this issue Apr 22, 2021 · 37 comments

Comments

@PatrykLeczycki
Copy link

I think it would be nice to have some info about value of quest reward items, maybe somewhere in this area:

image

During events with -50% cooldown for quests it would be much faster to accept quests with rings/amulets as reward by just looking on some numbers rather than pointing at every single reward item.

@GreatApo
Copy link
Member

image

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 24, 2021

A green from me, looking good!

@GreatApo GreatApo changed the title Quest reward value info Quest reward info Jan 9, 2022
@GreatApo GreatApo changed the title Quest reward info Quest item reward info Jan 9, 2022
@GreatApo
Copy link
Member

GreatApo commented Jan 9, 2022

Add item name too

@SleepingShadow-bit
Copy link
Collaborator

Add item name too

@GreatApo @FrutyX Can someone tell me where to find the name? Should this be displayed?

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 29, 2022

No, I think it wasn't scripted, only suggested.

@SleepingShadow-bit
Copy link
Collaborator

Ooops, i understand that was a script =)

FrutyX added a commit that referenced this issue Nov 5, 2022
@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

God be with us.

It ain't perfect, I know.

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Maybe if Apo is lurking, he can tweak it so the css is applied only on quests with an item, probably... I am not sure.

FrutyX added a commit that referenced this issue Nov 5, 2022
@FrutyX FrutyX added this to the v4.3.8 milestone Nov 5, 2022
@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Or you think it's fine like this? I mean, I wouldn't say it's a big deal, if it's empty, then well... no item reward, lol.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

Or you think it's fine like this? I mean, I wouldn't say it's a big deal, if it's empty, then well... no item reward, lol.

image

Is this better? I don't like the current solution

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

There is a reason, why it's not there, you know how long the item names are? You should know that, when Greek got a very long words, there was no way I could fit the names in there.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

There is a reason, why it's not there, you know how long the item names are? You should know that, when Greek got a very long words, there was no way I could fit the names in there.

I have only the prefix presented, not the rest of the name :) (the whole name doesn't fit in the UI and it is not scalable)

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

example

Lucky me, this is a very good example.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

example

Lucky me, this is a very good example.

Fruty, I am showing only the preffix (eg. Quintas)

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

You could potentially show only the prefix/suffix (if that is possible) but that sounds more like a downgrade honestly.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

It partially is but I don't see how this can nicely fit in the UI (that black line there is because the bg image doesn't scale)

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Well, another approach would be to create a completely new element under it, basically the same like now but nice (with it's own design), but that will require rewriting the code, most of it, I guess.

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

With some logic, I suppose people hunt for prefixes and suffixes, so yes, you could do that, but I seriously leave that only to you, because I already had some hiccups with this already, and the outcome isn't perfect, as you can see.

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

At first, I was playing with it a lot, because I didn't wanted to add it to a new line, but like I said, there is no way you can fit the full name there, even with some css edits, it was just bad. And I didn't get any other ideas, because you do this to get rid of the hover effect, that's the point, so your options are very limited.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

image
What about this? It will cut the text it is longer but it is the best/nice we can do (they can still mouse over!)

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Look, if you like it more, implement it. But again, people want to see it, so they don't have to hover over the image, if you cut it and add a mouse over, how different will that be from hovering over the image?

It really depends on the language, some names will be alright, some, like Greek, will be with a hidden overflow.

But I guess it's better than my implementation.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

I think it is a nice and neat solution that doesn't interfere a lot with the UI and it will work most of the time :)
People are basically after the prefix in underworld...

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

time

By the way, some quests are time limited and have an timer, it could collide? There isn't much space.

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Yes, the idea and implementation isn't difficult, placing it in the UI layout, that's a damn mystery.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

time

By the way, some quests are time limited and have an timer, it could collide? There isn't much space.

It works:
image

XD

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Actually, it does, if you do some css changes, you could move the time, if it will not collide with the upper text.

@GreatApo
Copy link
Member

GreatApo commented Nov 5, 2022

image

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

Yeah, that's actually pretty good, and I doubt any language text will touch that, not even Greek seems to be that long (lol).

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 5, 2022

ngl, this is a close one:
close

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 6, 2022

I don't know how the final result will look like, but playing with this width, you can move the whole rewards sections more closely to the "Reward:" area. Perhaps? It would buy you more space for the item.

width

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 6, 2022

In the end you'll rewrite the whole layout lmao, that's something I was trying to avoid, but sometimes there is no choice.

@GreatApo
Copy link
Member

GreatApo commented Nov 6, 2022

image

I just found how to scale the bg... hahaha

@GreatApo
Copy link
Member

GreatApo commented Nov 6, 2022

Is it better aligned?
image

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 6, 2022

lol, well, now that is a solution too... Yeah, that's good as well.

GreatApo added a commit that referenced this issue Nov 6, 2022
This reverts commit 9713659.
GreatApo added a commit that referenced this issue Nov 6, 2022
This reverts commit e5a4d3a, reversing
changes made to 8d285b8.
GreatApo added a commit that referenced this issue Nov 6, 2022
@GreatApo
Copy link
Member

GreatApo commented Nov 6, 2022

Nice! Good job!

@GreatApo GreatApo closed this as completed Nov 6, 2022
@FrutyX
Copy link
Collaborator

FrutyX commented Nov 6, 2022

Nice! Good job!

No, you good job! :D

At last, I think some people will appreciate this feature.

Two heads are better than one.

@GreatApo
Copy link
Member

GreatApo commented Nov 6, 2022

Two heads are better than one.

Always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants