-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the divine chest in battle reports #313
Comments
- There is a bug in cache (change page, go back, sometimes the reward is not shown) - I need to double check if chests are given from both arenas (to reduce requests)
Not finished yet:
|
It does drop in both arenas. |
Maybe you could flag only successful attacks, because the chest does not drop when you lose a fight. |
Good idea |
Today i make a Video about the feature. Truhe.mp4 |
Indeed, noticed it too, but I was waiting for another shot to test it, it does not appear immediately, you have to revisit the reports page. |
I have seen that too (I also reported that at the top) but I can't find why it happens... Maybe @GramThanos can do a quality check... |
Found the problem, I messed the asynchronous requests... |
We good on this feature, no problem found. |
Yes. Same here. No Problems |
Not confirmed. |
Yep, so I am unable to confirm or deny it, I have probably seen once or twice a case, where it does not get loaded (only after a refresh), but now, a few days, it's been showing normally. |
Show the "Chest of Divine Fate" in battle reports list, the same way as item drops are listed:
The best way (probably) to approach this would be, to save the report id (when it drops) and write it after in the reports list, so GCA doesn't have to check every single report, which would create server load.
The reason:
Sometimes, I forget if I farmed the chest that day, so I have to check every single report to see if I got it.
The text was updated successfully, but these errors were encountered: