Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the divine chest in battle reports #313

Closed
FrutyX opened this issue Dec 28, 2021 · 12 comments
Closed

Show the divine chest in battle reports #313

FrutyX opened this issue Dec 28, 2021 · 12 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 28, 2021

Show the "Chest of Divine Fate" in battle reports list, the same way as item drops are listed:

vyprav
enemy
chest

The best way (probably) to approach this would be, to save the report id (when it drops) and write it after in the reports list, so GCA doesn't have to check every single report, which would create server load.

The reason:

Sometimes, I forget if I farmed the chest that day, so I have to check every single report to see if I got it.

GreatApo added a commit that referenced this issue Dec 29, 2021
- There is a bug in cache (change page, go back, sometimes the reward is not shown)
- I need to double check if chests are given from both arenas (to reduce requests)
@GreatApo
Copy link
Member

Not finished yet:

  • There is a bug in cache (change page, go back, sometimes the reward is not shown)
  • I need to double check if chests are given from both arenas (to reduce requests)

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 29, 2021

  • I need to double check if chests are given from both arenas (to reduce requests)

It does drop in both arenas.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 29, 2021

(to reduce requests)

Maybe you could flag only successful attacks, because the chest does not drop when you lose a fight.

@GreatApo
Copy link
Member

Maybe you could flag only successful attacks, because the chest does not drop when you lose a fight.

Good idea

@SleepingShadow-bit
Copy link
Collaborator

Today i make a Video about the feature.
I had to load the page 2x to make it visible - is it correct?

Truhe.mp4

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 31, 2021

Indeed, noticed it too, but I was waiting for another shot to test it, it does not appear immediately, you have to revisit the reports page.

@GreatApo
Copy link
Member

I have seen that too (I also reported that at the top) but I can't find why it happens... Maybe @GramThanos can do a quality check...

GreatApo added a commit that referenced this issue Dec 31, 2021
@GreatApo
Copy link
Member

Found the problem, I messed the asynchronous requests...

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 1, 2022

We good on this feature, no problem found.

@SleepingShadow-bit
Copy link
Collaborator

We good on this feature, no problem found.

Yes. Same here. No Problems

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 15, 2022

@GreatApo for some reason, the problem is back, after you get your chest and check your reports, it is not visible, you have to refresh the reports page to see it.

Maybe someone else test this... I am using Google Chrome v97 (GCA v4.3.6).

Not confirmed.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 19, 2022

Yep, so I am unable to confirm or deny it, I have probably seen once or twice a case, where it does not get loaded (only after a refresh), but now, a few days, it's been showing normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants