Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online Friends - dont show family #314

Closed
SleepingShadow-bit opened this issue Dec 29, 2021 · 16 comments
Closed

Online Friends - dont show family #314

SleepingShadow-bit opened this issue Dec 29, 2021 · 16 comments

Comments

@SleepingShadow-bit
Copy link
Collaborator

Hello guys, can u check the list about online friends?
My list dont show my family friends
Enable_Select_Friend_YY

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 29, 2021

What version of GCA are you using?
What browser are you using?
Are there any errors in the console (press F12, errors are red, disable uBlock/AdBlock before doing so).

Sadly I cannot check this (I don't have any friends :( :D ).

@SleepingShadow-bit
Copy link
Collaborator Author

Current Github Version 4.3.5
Version 96.0.4664.110 (Offizieller Build) (64-Bit)
F12 = no Errors. No AdBlock using!

My guildmates have the same problem

:D :D

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 29, 2021

But your guildmates are not using the Github version, right? So it's also in 4.3.4, well maybe it never worked (did it?), I am not even sure.

@SleepingShadow-bit
Copy link
Collaborator Author

My guild mate use the official 4.3.4 with opera gx browser.

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 29, 2021

Yeah, I'll leave it to Gram & Apo, since they can test it on each other and I don't have to create another acc.

@GramThanos
Copy link
Member

Hey! Can you send me a screenshot of your fiends list and also maybe a screen shot of the console (open online players modal, right click the page and select inspect element, then select the console tab on the new panel). If you don't want to post it here, send me an email at gramthanos@gmail.com

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 29, 2021

Maybe it works, but some symbols in player names are stopping it... or diacritics.

@SleepingShadow-bit
Copy link
Collaborator Author

SleepingShadow-bit commented Dec 29, 2021

@GramThanos i send you an email

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 31, 2021

Maybe it works, but some symbols in player names are stopping it... or diacritics.

Tested this, not the case.

@SleepingShadow-bit
Copy link
Collaborator Author

Could you test the friends list?
And do u have some errors? Maybe I can't handle the error console =)

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 1, 2022

I did, there is no error, no problem visible, but the list is not loading, either a small change is needed, or the script needs to be completely reworked, but the guild list does work.

@GramThanos
Copy link
Member

I have done some testing and changes based on @SleepingShadow-bit 's feedback (he gave me more info through email), but I havent pushed them because of the new version. One problem is that the addon fails to detect friends that are not in a guild.

@SleepingShadow-bit can you also send me through email your friends table in html?
To do that follow the steps:

  • go to the friends page
  • right click and select view source
  • use ctrl+f to serach for <section>
  • copy from the <section> up to the </section>
  • replace any sh=abcd... with sh=xxxxxx..

Here is an example of my table:

<section>
   <table border="0" cellpadding="2" cellspacing="2" style="width:100%;">
   	<tr>
   		<th style="max-width:100px;overflow:hidden;">Όνομα</th>
   		<th>Τάγμα</th>
   		<th>Επίπεδο</th>
   		<th>Κατάσταση</th>
   		<th>&nbsp;</th>
   	</tr>

   							<tr>
   			<td style="max-width:100px;overflow:hidden;"><a href="index.php?mod=player&p=119682&sh=XXXXXXXXX" title="GreatApo">GreatApo</a></td>
   			<td><a href="index.php?mod=guild&i=19676&sh=XXXXXXXXX" >[ENOMENOI]</a></td>
   			<td>144</td>
   			<td><span style="color: red; font-weight: bold;" title="off">12:58:52</span></td>
   			<td valign="middle">
   																						<a href="index.php?mod=messages&submod=messageNew&profileName=GreatApo&sh=XXXXXXXXX">γράψε μήνυμα</a>
   														&nbsp;<a href="index.php?mod=overview&submod=buddylist&amp;bid=119682&amp;action=delete&sh=XXXXXXXXX">Αφαιρώ</a>
   											</td>
   		</tr>

   											</table>
</section>

@SleepingShadow-bit
Copy link
Collaborator Author

SleepingShadow-bit commented Jan 1, 2022

At the moment i have a friend who isnt in my guild.
if u dont wont the code here, i will edit and send u an Email

Edit: ok i have a Problem to upload the code
Friendslist.txt

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 1, 2022

Hmmm, I found out, on Glad. forums, that there has been already some problems with this (in 2019).

I think this feature has to be burned with fire 🔥 before it lays eggs 🥚.

Edit: Oh, and there was also this #176.

@SleepingShadow-bit
Copy link
Collaborator Author

SleepingShadow-bit commented Jan 3, 2022

For me =)
IMG_20220103_184145

Thank u.

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 13, 2022

Tested, working. Noted on the progress list.

Closing, re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants