Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smelting time shown on items #350

Closed
HodajuciDjed opened this issue Apr 30, 2022 · 26 comments
Closed

Smelting time shown on items #350

HodajuciDjed opened this issue Apr 30, 2022 · 26 comments

Comments

@HodajuciDjed
Copy link

Hello, fist of I love all the work that's done to improve the quality of the game with the addon significantly! Good job!

Is there any chance you can put smelting time for items on their tooltip somewere like the materials or just outright below the level? (I have added pictures to better illustrate what I meant)

I am a level 120 and if you actively play you know the strugle of 5-10 pages of smelting items in packages.
It would be a huge time saver because I need to move items to my already "full" bags to see if items are done smelting by the morning or by the time I get of work, a small thing but I think a great addition as this way I can choose them in the packages and I don't need to repack them to save space.

paketi
tooltip

Best regards!

@FrutyX
Copy link
Collaborator

FrutyX commented Apr 30, 2022

I can't promise that it will be added (in some way), but I like the idea! I also keep having too much stuff to melt, this would help.

@GramThanos
Copy link
Member

We have to find the formula first.
I expect it to be something like:

seconds = ((item-level * item-type) * item-quality) / server-speed

@HodajuciDjed
Copy link
Author

Sweet, glad you like it and find it usefull. I understand isn't not a priority it's a small thing just something to keep in mind for future updates :D

@GreatApo
Copy link
Member

From a quick data analysis, the smelting time seems to be related to the item value:
total time in seconds = value * 0.93745

Can anybody else verify this? And an example on a speed server will be useful...

image

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 26, 2022

There is so much data needed for this...

Wouldn't it be easier to do something like this and just simulate it with it (via smelter free slot)?

hammer

Of course it's a bit away from the original idea, but, you know.

@GreatApo
Copy link
Member

Actually if what I found works for all levels, then it is quite easy to add the time in the tooltips

@SleepingShadow-bit
Copy link
Collaborator

i will check out after the smelting event.
i am on a x4 server

@FilipSla
Copy link

The coefficients are similar for me and according to server speed you can just divide/multiply them 😃
image

@GreatApo
Copy link
Member

The coefficients are similar for me and according to server speed you can just divide/multiply them 😃

I think that's a green light

GreatApo added a commit that referenced this issue Jun 28, 2022
…ltip (#350)

- Forging time is double in underworld???
@GreatApo
Copy link
Member

Forging time is double in underworld? We will see if the times still work once I get out...

image

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

Double? No, that has to be a bug.

@GreatApo
Copy link
Member

Double? No, that has to be a bug.

It seems it is double in underword:
image
image
(last item is while in underworld)

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

Ehm, I am not in the underworld. Speed x5

hmmm

@GreatApo
Copy link
Member

Ehm, I am not in the underworld. Speed x5

There was an event with faster forging times, dig I got all my measurements by half? hahaha

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

Yes, I think you did exactly that. It was 50%.

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

Also I noticed that if you move them item (drag), the time will disappear.

@GreatApo
Copy link
Member

Also I noticed that if you move them item (drag), the time will disappear.

I think that happens with the forge tooltip in general

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

You right.

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 28, 2022

2 secs difference now :P.

@GreatApo
Copy link
Member

2 secs difference now :P.

Yeah, that's not going to be exact :P

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 29, 2022

This has to be related, it's new, it happened in packages, amulets only section.
error

Could be something random, maybe when I was getting them, hard to say, can't trigger it, yet.

@SleepingShadow-bit
Copy link
Collaborator

SleepingShadow-bit commented Jun 29, 2022

Is it possible to implement the melting time in the advanced filter (#343)as well?
For example Less than 3h melting time

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 29, 2022

Yea, I guess, however the advanced filter is so outdated now, that no one dares to touch it :D.

@SleepingShadow-bit
Copy link
Collaborator

I also have to admit that I don't use the advanced filter. I never need the search option that is implemented :) However, there are very good ideas in the topic #343

@GreatApo
Copy link
Member

This has to be related, it's new, it happened in packages, amulets only section.

Could be something random, maybe when I was getting them, hard to say, can't trigger it, yet.

Not related, I improved the code to refresh the tooltip when moving items. It must be fixed now.

Is it possible to implement the melting time in the advanced filter as well?

I will post it under the relevant issue

@FrutyX FrutyX added this to the v4.3.6 milestone Jul 23, 2022
@FrutyX
Copy link
Collaborator

FrutyX commented Sep 13, 2022

Implemented in v4.3.6, closing, re-open if needed.

@FrutyX FrutyX closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants