Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll container width keeps increasing on mouseout on Firefox 61 on Mac #181

Open
davkal opened this issue Jul 26, 2018 · 1 comment
Open

Comments

@davkal
Copy link

davkal commented Jul 26, 2018

The broken behaviour is described here:
grafana/grafana#12726

I think we're hitting a FFMAC special case in baron, our scroll handler. It adds padding (15px) on each scroll element update:
https://github.com/Diokuz/baron/blob/master/src/core.js#L596

The update here is triggered on an animation or transition event on hover:
https://github.com/Diokuz/baron/blob/master/src/core.js#L209

To verify, you can change your user agent to not match the regexp in https://github.com/Diokuz/baron/blob/master/src/core.js#L46 and the issue disappears.

My guess is that baron no longer needs this special treatment in FF61

ViViDboarder added a commit to ViViDboarder/baron that referenced this issue Oct 29, 2018
This is no longer required.

Fixes Diokuz#181
@ViViDboarder
Copy link

@davkal I wrote a patch (referenced in this PR), but want to verify it. Any idea how I can reproduce using the test page? I'm not quite familiar enough with what Grafana is doing to create a good test.

I'm looking at test/index.html and none of the test examples seem to reproduce the issue, even on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants