CI: Enable clippy #101
CI: Enable clippy #101
Conversation
.github/workflows/main.yml
Outdated
| override: true | ||
| - uses: Swatinem/rust-cache@v1 | ||
| - run: sudo apt-get update | ||
| - run: sudo apt install libwebkit2gtk-4.0-dev libappindicator3-dev libgtk-3-dev libappindicator3-dev |
There was a problem hiding this comment.
Clippy would eventually fail when checking the code looking for the 'pango' package, so I added all the dependencies we need for compiling on ubuntu-latest.
There was a problem hiding this comment.
Cool, thank you for doing that. I accidentally added libappindicator3 twice, so maybe we want to remove that.
| @@ -745,6 +745,7 @@ impl ScopeState { | |||
| /// use_hook(|| Rc::new(RefCell::new(initial_value()))) | |||
| /// } | |||
| /// ``` | |||
| #[allow(clippy::mut_from_ref)] | |||
There was a problem hiding this comment.
I'm not qualified to determine whether the mut_from_ref usage here is sound so I allowed it.
There was a problem hiding this comment.
There's a bunch of safety dynamics to enable borrowed lifetimes through the tree, and this is the consequence :/
| @@ -1,3 +1,4 @@ | |||
| #![allow(warnings)] | |||
There was a problem hiding this comment.
Since this package is very much WIP, I didn't see the point in allowing or fixing each instance individually. We'll need to remove this once the package is closer to ready.
| @@ -38,6 +38,7 @@ impl SsrRenderer { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(clippy::needless_lifetimes)] | |||
There was a problem hiding this comment.
I believe the below could be
pub fn render_lazy(f: LazyNodes<'_, '_>) -> String {But since we name the lifetimes in the Safety comment below, I allowed it.
.github/workflows/main.yml
Outdated
| override: true | ||
| - uses: Swatinem/rust-cache@v1 | ||
| - run: sudo apt-get update | ||
| - run: sudo apt install libwebkit2gtk-4.0-dev libappindicator3-dev libgtk-3-dev libappindicator3-dev |
There was a problem hiding this comment.
Cool, thank you for doing that. I accidentally added libappindicator3 twice, so maybe we want to remove that.
| @@ -745,6 +745,7 @@ impl ScopeState { | |||
| /// use_hook(|| Rc::new(RefCell::new(initial_value()))) | |||
| /// } | |||
| /// ``` | |||
| #[allow(clippy::mut_from_ref)] | |||
There was a problem hiding this comment.
There's a bunch of safety dynamics to enable borrowed lifetimes through the tree, and this is the consequence :/
This PR enables clippy and applies a few fixes to make it lint successfully. See additional comments below.