The desktop app will default open link in browser

[mrxiaozhuox]

No description provided.

[mrxiaozhuox]

wait please, I will add a remove-browser-open attribute

[mrxiaozhuox]

I use browser-href to replace the href, because I think we don't any way prevent <a> redirect. So defulat I will change the href to the #

[jkelleyrtp]

This is a good start, but I'd like to see this code moved into the event handler instead of setattribute.

We use listener multiplexing - so there's only one click handler for the whole app. Adding more handlers to the app manually might interfere with our global handling.

Instead of having this code here, we need it to either go in the Rust side where we receive events from webview, or in the AddEventListener code where we create the global listeners.

Additionally, instead of the "browser-open" attribute, we should just look at the URL itself and make the decision automatically. If it starts with a protocol (ie wry:// or dioxus:// - or anything that's not http:// or https://) then we want the url to move through the handler infrastructure.

Also - any onclick in Desktop should have "default prevented" - that way we don't need to mess with window.location. By calling "prevent default", the history will be preserved properly, so we can still provide links into a desktop app from the outside.

To recap:

• Move rpc.call into the "add event listener"
• Always call "prevent-default" for onclick events in desktop
• Parse URL or "prevent_default" attribute instead of "browser-open" flag

[jkelleyrtp]

Add a check that href isn't null/undefined and then remove the console.log and we're good to go :)

[jkelleyrtp]

Looks great :) Thank you!