Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain Props lifetime to parent, not child scope lifetime #1345

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 13, 2023

The current props lifetimes allow you to borrow any data including temporary data. This change makes it so that the data must last at least as long as the 'bump lifetime of the scope.

Closes #1341

@ealmloff ealmloff added bug Something isn't working core relating to the core implementation of the virtualdom labels Aug 13, 2023
@ealmloff ealmloff requested a review from jkelleyrtp August 15, 2023 12:18
@jkelleyrtp jkelleyrtp merged commit a38860e into DioxusLabs:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core relating to the core implementation of the virtualdom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing borrowed array turns into a different array
2 participants