Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaked signals created in effects #1386

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

ealmloff
Copy link
Member

Currently any signals created in an effect use the root scope as the owner. This essentially leaks the signal for the duration of the application. Instead this sets the owner of signals created in effects to the owner of the effect

@ealmloff ealmloff added bug Something isn't working signals Related to the signals crate labels Aug 21, 2023
@jkelleyrtp jkelleyrtp merged commit 30b958f into DioxusLabs:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working signals Related to the signals crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants