Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prettier_build unavailabe #1410

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Conversation

mrxiaozhuox
Copy link
Contributor

@mrxiaozhuox mrxiaozhuox commented Aug 31, 2023

This PR fixed prettier_build function. we covered default cargo build console and make it more concise.

@ealmloff
Copy link
Member

What issue does this fix with the prettier_build function?

@mrxiaozhuox
Copy link
Contributor Author

What issue does this fix with the prettier_build function?

prettier_build will cover default cargo build print, but currently prettier will use old build print. so it useless yet.

@ealmloff
Copy link
Member

ealmloff commented Aug 31, 2023

prettier_build will cover default cargo build print, but currently prettier will use old build print. so it useless yet.

Sorry, I'm still not entirely sure I understand what the PR changes. When running the CLI in both versions, the cargo build output flashes on the screen and then is covered up by the status screen so it looks like the build function doesn't cover up the cargo build yet.

Does this PR start to implement a prettier build function but doesn't add any new functionality/bug fixes yet?

@ealmloff ealmloff added the cli Related to the dioxus-cli program label Aug 31, 2023
@mrxiaozhuox
Copy link
Contributor Author

prettier_build will cover default cargo build print, but currently prettier will use old build print. so it useless yet.

Sorry, I'm still not entirely sure I understand what the PR changes. When running the CLI in both versions, the cargo build output flashes on the screen and then is covered up by the status screen so it looks like the build function doesn't cover up the cargo build yet.

Does this PR start to implement a prettier build function but doesn't add any new functionality/bug fixes yet?

I just replace the default cargo build information, just have one line build info, and new building project will cover finished.

2023-09-02.13.48.08.mov

this style is better for hot-reload (rebuild), the console page will be not scroll down, so we can keep display service information.

@ealmloff
Copy link
Member

ealmloff commented Sep 2, 2023

prettier_build will cover default cargo build print, but currently prettier will use old build print. so it useless yet.

Sorry, I'm still not entirely sure I understand what the PR changes. When running the CLI in both versions, the cargo build output flashes on the screen and then is covered up by the status screen so it looks like the build function doesn't cover up the cargo build yet.
Does this PR start to implement a prettier build function but doesn't add any new functionality/bug fixes yet?

I just replace the default cargo build information, just have one line build info, and new building project will cover finished.

2023-09-02.13.48.08.mov
this style is better for hot-reload (rebuild), the console page will be not scroll down, so we can keep display service information.

I see now, thank you! That looks much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants