Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate serve code with hot reloading in the CLI crate #1446

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Sep 9, 2023

Combines some code in the CLI that serves the hot reload and non-hot reload version of the cli.

This fixes some issues that were applied to only the non-hot-reloading version of the code. Fixes #1041.

This will also fix hot rsx reloading after any changes that require a full rebuild happens. For example after this change:

p { "{10 * 10}" }
->
p { "{10 * 20}" }

The page reloads but this change currently fails to hot reload:

p { "{10 * 20}" }
->
p { "{10 * 20}" }
"This should be hot reloadable"

This PR makes the second change hot reloadable.

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Sep 9, 2023
@jkelleyrtp
Copy link
Member

Perfect - I think this was the issue I was seeing with hotreloading before!

@jkelleyrtp jkelleyrtp merged commit e59a051 into DioxusLabs:master Sep 16, 2023
@ealmloff ealmloff deleted the deduplicate-hot-reload-cli branch September 17, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload causes browser to refresh page multiple times per change
2 participants