Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional web support for hot-reload crate #1527

Merged

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Oct 6, 2023

Changes in hot-reload

  • Enable dioxus-html by default but make it optional
  • New custom_file_watcher feature, it's like the old file_watcher but doesn't depend on dioxus-html, I will use this one for Freya with default-features = false so web is disabled
  • file_watcher feature now just enables custom_file_watcher and dioxus-html

No breaking changes and I will be able to not pull dioxus-html in freya

@ealmloff ealmloff added the hot-reload Related to the hot reload crate label Oct 6, 2023
@marc2332 marc2332 marked this pull request as ready for review October 11, 2023 16:03
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@ealmloff ealmloff merged commit 129d0a6 into DioxusLabs:master Oct 20, 2023
19 checks passed
@marc2332 marc2332 deleted the feat/optional-web-support-for-hot-reload branch October 21, 2023 07:19
@jkelleyrtp jkelleyrtp added this to the 0.5 Release milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-reload Related to the hot reload crate
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants