Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an readable error when you name a prop key #1558

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add an readable error when you name a prop key #1558

merged 2 commits into from
Oct 23, 2023

Conversation

ealmloff
Copy link
Member

Adds a more legible error to fix #1557

@ealmloff ealmloff added enhancement New feature or request core relating to the core implementation of the virtualdom tweak Small changes to improve experience labels Oct 19, 2023
@jkelleyrtp jkelleyrtp enabled auto-merge October 23, 2023 20:58
@jkelleyrtp jkelleyrtp merged commit 647815f into DioxusLabs:master Oct 23, 2023
10 checks passed
@jkelleyrtp jkelleyrtp added this to the 0.5 Release milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
core relating to the core implementation of the virtualdom enhancement New feature or request tweak Small changes to improve experience
Projects
🧬 Dioxus Roadmap
Status: Done
Milestone
0.5.0: Signals
Development

Successfully merging this pull request may close these issues.

#[component] macro should fail to compile if one of the props is named key
2 participants
@ealmloff @jkelleyrtp