DesktopContext Wrap & Inject

[mrxiaozhuox]

DesktopContext provide some api to control window, like drag_window minimized maximized.

[mrxiaozhuox]

#160 I think this PR can help you.

[jkelleyrtp]

Looks great! Really awesome feature and great job on the code. Very excited to have this demo.

One change:

To make it easier for people to get the desktop context, lets provide a hook that does it for them. Maybe something like use_window.

[jkelleyrtp]

Just a nit - can we standardize some language on the methods?

The methods added are

• drag window
• minimize
• maximize
• focus

Should each of these methods be xxx_window? like minimize_window?

If the hook was use_window then calling drag_window would be redundant. Does the hook provide context just for the current window or all windows (eventually)? Let's make sure whatever we go with, our naming is consistent, keeping in mind that we want to support multiwindow in the near future without breaking the APIs used here.

I think it would be clearer to specify that this hook applies to the current window (ie use_window gets the current window context) and then have the methods be just drag, minimize, maximize, and focus, since you'll likely be calling window.drag() or window.minimize() rather than desktop.minimize(). It seems that desktop.minimize() minimize all the windows.

[mrxiaozhuox]

Just a nit - can we standardize some language on the methods?

The methods added are

• drag window
• minimize
• maximize
• focus

Should each of these methods be xxx_window? like minimize_window?

If the hook was use_window then calling drag_window would be redundant. Does the hook provide context just for the current window or all windows (eventually)? Let's make sure whatever we go with, our naming is consistent, keeping in mind that we want to support multiwindow in the near future without breaking the APIs used here.

I think it would be clearer to specify that this hook applies to the current window (ie use_window gets the current window context) and then have the methods be just drag, minimize, maximize, and focus, since you'll likely be calling window.drag() or window.minimize() rather than desktop.minimize(). It seems that desktop.minimize() minimize all the windows.

ok

[jkelleyrtp]

Looks great! Good job on the code!