Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nodes being unmounted when used in highly nested contexts #182

Merged
merged 17 commits into from
Feb 1, 2022

Conversation

jkelleyrtp
Copy link
Member

This PR fixes #179 and an additional bug that @t1m0t found regarding state consumption in highly nested shared-node contexts.

Instead of the custom fiber implementation, this PR is choosing to switch back to a traditional recursive approach and then building fibers on top of rust's future infrastructure instead.

@jkelleyrtp jkelleyrtp marked this pull request as ready for review February 1, 2022 15:23
@jkelleyrtp jkelleyrtp merged commit 80d7929 into master Feb 1, 2022
@jkelleyrtp jkelleyrtp deleted the jk/debugging-diff branch February 4, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panicked at 'called Option::unwrap() on a None value' > /packages/core/src/scopes.rs:172:48
1 participant