fix: remove code generation entirely #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should rerun the tests (workflow has been fixed) |
|
Amusingly the v0.2 release notes mention the interpreter is "now (...) written in TypeScript", but that seems to have no longer been the case for over a month 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a nice idea to have tsc generate our js binding files, but it leads to weird changes in PRs and noticeably slows down compilation.
This PR moves the binding code into the jsinterpreter crate so we can service both desktop and web from the same crate and same single
.jsfile.It seems that other projects that use bindings like this just write all their bindings in JS with heavy linting, so that's what we're going to follow until it becomes impossible.
Also, as a side-effect, we've fixed #173