Code coverage setup #214
Merged
Code coverage setup #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=========================================
Coverage ? 37.25%
=========================================
Files ? 67
Lines ? 4839
Branches ? 0
=========================================
Hits ? 1803
Misses ? 3036
Partials ? 0 Continue to review full report at Codecov.
|
|
Is this ready for merge? |
|
There is still a lack of support for wasm so the coverage indicator is not perfect but still it is better than nothing. We should keep track of this issue in another ticket otherwise it is ok for merging imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up code coverage locally with tarpaulin and adapt ci workflow