Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up use_on_destroy docs #2199

Merged

Conversation

marc2332
Copy link
Contributor

Changes

  • Remove use_on_create as it was already commented out
  • Update use_on_destroy deprecation notice

@DogeDark DogeDark added documentation Improvements or additions to documentation hooks Changes to built-in hook package labels Mar 31, 2024
Copy link
Member

@DogeDark DogeDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs rustfmt fixed

@marc2332 marc2332 requested a review from DogeDark March 31, 2024 14:49
@ealmloff ealmloff merged commit 7949fcd into DioxusLabs:main Apr 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hooks Changes to built-in hook package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants