Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all the css #233

Merged
merged 3 commits into from
Feb 26, 2022
Merged

feat: add all the css #233

merged 3 commits into from
Feb 26, 2022

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Feb 11, 2022

Our CSS catalog wasn't entirely fleshed out. This fixes that, adding all the css I could find.

Notably, it includes "grid". Fixes #229.

I'm pulling from this list:

https://gist.github.com/simurai/40902209f695b2d080e1

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #233 (9f60dfa) into master (4a3680e) will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   37.45%   36.26%   -1.20%     
==========================================
  Files          63       63              
  Lines        4816     4975     +159     
==========================================
  Hits         1804     1804              
- Misses       3012     3171     +159     
Impacted Files Coverage Δ
packages/html/src/global_attributes.rs 40.00% <ø> (ø)
packages/web/src/dom.rs 0.00% <0.00%> (ø)
packages/desktop/src/lib.rs 0.00% <0.00%> (ø)
packages/desktop/src/desktop_context.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3680e...9f60dfa. Read the comment docs.

@jkelleyrtp jkelleyrtp merged commit 0da1897 into master Feb 26, 2022
@jkelleyrtp jkelleyrtp deleted the jk/all-the-css branch April 27, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable grid attributes
1 participant