Clean up desktop's index.html #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially I wanted to delete only the duplicated `<html>` opening tag, but then decided to make it a fully valid HTML document. Passes https://validator.w3.org/nu/#textarea check.
asaaki
commented
Feb 12, 2022
| </script> | ||
|
|
||
| <head> | ||
| <title>Dioxus app</title> |
There was a problem hiding this comment.
This is not strictly necessary for dioxus, but turns this file into a fully valid document.
It get's overwritten by dioxus or the user's application configuration anyway.
There was a problem hiding this comment.
I don't know should we add this title tag. but maybe it doesn't matter.
|
looks good, you have format the HTML code. |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 63 63
Lines 4880 4880
=======================================
Hits 1804 1804
Misses 3076 3076 Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I wanted to delete only the duplicated
<html>opening tag, but then decided to make it a fully valid HTML document.Passes https://validator.w3.org/nu/#textarea check.