Disable reload context menu in production #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
changed the title
mrxiaozhuox
reviewed
Feb 20, 2022
| @@ -174,7 +174,25 @@ pub fn launch_with_props<P: 'static + Send>( | |||
| } | |||
|
|
|||
| if cfg!(debug_assertions) { | |||
| // in debug, we are okay with the reload menu showing and dev tool | |||
There was a problem hiding this comment.
we will keep menu in debug mode ?
There was a problem hiding this comment.
We want to provide the inspect element tool in debug which means we need to keep the menu around. So, yes.
mrxiaozhuox
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webview will never get custom context menus (the thing when you right click), so it's up to app authors to implement their own context menus. A library for making that easier will be very helpful to the Dioxus ecosystem.
Anyways, this PR adds an initialization script in release mode that disables the context menu altogether, since having a right click menu that just shows reload is probably not super helpful to most users.