Bump dependencies to transitively bump git2 from 0.18 to 0.19 #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
approved these changes
Aug 23, 2024
pyrrho
added a commit
to pyrrho/dioxus
that referenced
this pull request
Aug 28, 2024
…Labs#2873) * Bump built to version 0.7.4 * Bump cargo-generate to 0.21.3 * Update Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made to resolve a dependency graph issue I hit in my own repository when building with
[patch.crates-io.dioxus] path = ...."directives in my Cargo.toml -- so not actually an issue in the Dioxus repo.I'm not sure this is a safe or correct dependency bump.
Both built and cargo-generate were set to exact version matches across the Dioxus repo, which makes me think there's a reason to not automatically select the most recent minor version of those packages. I do not know that reason, so this version bump may be... doing something scary? Buyer beware.
cc'ing @jkelleyrtp as the exact matches were (as far as I can tell from a very brief bit of review) introduced in #2258.