Don't run effects from dead recycled scopes

[ealmloff]

Fixes #3196 by removing effects queued for the scope as the scope itself is removed

[rogusdev]

Thanks for jumping on this! However, while these changes do stop the panic from the issue from happening, yes, but 2 things: 1. now it does not actually give the correct behavior with the expanded children when clicking between items and 2. the debug warnings are still present (or do you think those are from something else?)

[ealmloff]

Thanks for jumping on this! However, while these changes do stop the panic from the issue from happening, yes, but 2 things: 1. now it does not actually give the correct behavior with the expanded children when clicking between items and 2. the debug warnings are still present (or do you think those are from something else?)

One of the changes I made was causing tasks to be dropped without being polled (which was also causing tests to fail). That should be fixed now and your reproduction code works in debug and release. The warning should be fixed by #3194

[rogusdev]

Thanks can also confirm that it all now works. :)

Why was the warning happening in debug but not release, and the panic happening in release but not debug?

[ealmloff]

Why was the warning happening in debug but not release, and the panic happening in release but not debug?

We do extra checks when debug assertions are enabled including that warning. I'm not exactly sure why the panic was only happening in release mode, but it was caused by id allocation which could change based on the number of scopes or the order scopes are diffed in