Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Fixes #220

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Documentation Fixes #220

merged 9 commits into from
Mar 20, 2024

Conversation

DogeDark
Copy link
Member

@DogeDark DogeDark commented Mar 16, 2024

Fixes:

  • Desktop guide provides a GitHub search query to find examples using dioxus_desktop. You no longer need to import dioxus_desktop so this query results in nothing.
  • Desktop guide does not mention how to run the app without hot reload.
  • This code source was broken.
  • The first mention of needing r# for the type attribute is on the User Input page. Should mention it in the RSX page Attributes section too.
  • Duplicate text: "it could be stored in use_signal, use_signal, or a constant." Here
  • Web page eval example says Dioxus desktop and not Dioxus web.
  • Added a small section to the mobile guide to ensure you set your build variant in Android Studio.
  • Adds a little more context and information to make the hacker news project a little more accessible.

@DogeDark DogeDark marked this pull request as draft March 16, 2024 22:02
@DogeDark DogeDark marked this pull request as ready for review March 19, 2024 02:18
@ealmloff ealmloff added bug Something isn't working documentation Improvements or additions to documentation labels Mar 19, 2024
@DogeDark
Copy link
Member Author

DogeDark commented Mar 20, 2024

I believe CI is failing because of native core stuff. Evan's PR has it fixed so I'll wait for that to merge and then pull master back into this one.

Edit: I was wrong. Both are having the same issue.

@jkelleyrtp jkelleyrtp merged commit fe51933 into DioxusLabs:master Mar 20, 2024
1 check failed
@DogeDark DogeDark deleted the doc-fixes1 branch March 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants