Fix section links on right navigation bar, which don't work when punctuated #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ids are rendered differently when parsed from markdown and rendered, from when they are inserted into the vector that populates the right navigation bar. As a result, links on the right navigation bar do not work if they contain punctuation, or any characters besides
[0-9a-zA-Z\-]
.For example. on the page https://dioxuslabs.com/learn/0.6/, clicking the link Who's funding dioxus? appends
#who's-funding-dioxus?
to the url, but that anchor is rendered with theid="whos-funding-dioxus"
.So I just took the code that renders id for the section based on the title, and replicated it for the code that inserts the sections into the vector that populates the menu. Unfortunately these two
Section
structs are different, and the one that is used in rendering the page is private.