Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE.md #10

Closed
alice-i-cecile opened this issue May 11, 2022 · 5 comments · Fixed by #49
Closed

Update LICENSE.md #10

alice-i-cecile opened this issue May 11, 2022 · 5 comments · Fixed by #49
Labels
meta About the project itself

Comments

@alice-i-cecile
Copy link
Collaborator

  1. Remove from README (duplicative).
  2. Figure out how to properly credit both Stretch2 contributors and original Visly team.
@alice-i-cecile alice-i-cecile added the meta About the project itself label May 11, 2022
alice-i-cecile added a commit that referenced this issue May 11, 2022
This is redundant to README.md.

First half of #10.
alice-i-cecile added a commit that referenced this issue May 11, 2022
This is redundant to README.md.

First half of #10.
@mockersf
Copy link
Contributor

mockersf commented May 11, 2022

vislyhq/stretch#85 should also be merged in this repo so that crates.io can correctly display the license
vislyhq/stretch#97 probably too

@alice-i-cecile alice-i-cecile added this to the Release new crate milestone May 13, 2022
@TimJentzsch
Copy link
Collaborator

Stretch is licensed under MIT while bevy is dual-licensed with Apache as well. Is this going to cause issues?

@alice-i-cecile
Copy link
Collaborator Author

It won't cause issues; we can just leave this as a separate repo under just MIT.

@NickAcPT
Copy link

NickAcPT commented May 15, 2022

  1. Figure out how to properly credit both Stretch2 contributors and original Visly team.

Regarding this, I think the best action would be to add an extra line of copyright like explained in this Stack Exchange answer. Although the answer talks about a code port, I think it can still apply on a fork of a project.

So for this repo, adding something like the following below the existing Copyright line might be enough:

Copyright (c) 2022 Dioxus

@alice-i-cecile
Copy link
Collaborator Author

Copyright (c) 2022 Dioxus

I would change this to Stretch2 contributors (or whatever name we end up on), but otherwise this sounds great to me.

jkelleyrtp pushed a commit that referenced this issue Oct 10, 2022
This is redundant to README.md.

First half of #10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta About the project itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants