Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PositionType and Position in accordance to specs #295

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Rename PositionType and Position in accordance to specs #295

merged 6 commits into from
Dec 27, 2022

Conversation

Weibye
Copy link
Collaborator

@Weibye Weibye commented Dec 26, 2022

Objective

Fix #271

@Weibye Weibye requested review from alice-i-cecile and nicoburns and removed request for alice-i-cecile December 26, 2022 21:16
@alice-i-cecile alice-i-cecile added usability Make the library more comfortable to use code quality Make the code cleaner or prettier. breaking-change A change that breaks our public interface labels Dec 26, 2022
@nicoburns
Copy link
Collaborator

nicoburns commented Dec 26, 2022 •
edited
Loading

This looks good to me, but CSS Grid tests are failing because those files haven't been updated. You need to run tests with --features experimental_grid. And if you want Rust-Analyzer to pick up the grid modules you have to temporarily makes experimental_grid a default feature in Cargo.toml.

@alice-i-cecile This is becoming an increasingly annoying problem for me when working on Taffy. How would you feel about making the grid feature on by default? (and perhaps renaming it to just grid or css-grid?)

@alice-i-cecile
Copy link
Collaborator

I'm fine to enable them by default now!

alice-i-cecile
alice-i-cecile approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this once CI is passing.

@Weibye
Copy link
Collaborator Author

Weibye commented Dec 27, 2022

All should be fixed now :)

@nicoburns nicoburns merged commit e2cee9d into DioxusLabs:main Dec 27, 2022
@Weibye Weibye deleted the position-rename branch December 27, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@nicoburns nicoburns Awaiting requested review from nicoburns

Assignees
No one assigned
Labels
breaking-change A change that breaks our public interface code quality Make the code cleaner or prettier. usability Make the library more comfortable to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name of position and position_type properties doesn't match CSS spec
3 participants
@Weibye @nicoburns @alice-i-cecile