Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes a perf issue due to cache-thrashing that occurs with Flexbox columns.
Changes made
Increased caches slots per node from 7 to 9, and updated slot-assingment algorithm to make use of those extra slots. specifically, MinContent and MaxContent/Definite sizes are now cached separately in both axis.
Context
Found when investigating the following issues:
Potential future improvements
known_dimensions
are(None, None)
andavailable_space
is(MinContent, MinContent)
. So storing the value of those inputs as cache keys is unnecessary for that slot.