Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate 1.65 MSRV #781

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Reinstate 1.65 MSRV #781

merged 1 commit into from
Jan 8, 2025

Conversation

nicoburns
Copy link
Collaborator

Objective

  • Reinstate lower MSRV of Rust 1.65

Context

  • We want const constructors for values.
  • We were using f32::to_bits and f32::from_bits for this functionality since Use tagged pointer to represent size/length values #769
  • These functions were only stabilised in Rust 1.83
  • This PR inlines those functions into Taffy which allows us to reduce MSRV back to 1.65 at the cost of two lines of unsafe code.

@nicoburns nicoburns added the usability Make the library more comfortable to use label Jan 8, 2025
@nicoburns nicoburns merged commit 177d645 into DioxusLabs:main Jan 8, 2025
26 checks passed
@nicoburns nicoburns deleted the reinstate-1.65-msrv branch January 8, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
usability Make the library more comfortable to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicoburns