Fixed gadget being indicated as repairable, but isn't. #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /*@Override | ||
| public boolean isRepairable() { | ||
| @Override | ||
| public boolean isRepairable(ItemStack stack) { |
There was a problem hiding this comment.
You you look into the Block.Properties class and see if there is a property to set this in the constructor? This might be why I commented this out but might have used the wrong one. If you check Item class you should be able to see if this method uses one of those properties, if not then I'll accept 👍
There was a problem hiding this comment.
I see what you mean, canRepair should do the trick.
There was a problem hiding this comment.
Yeah, maxDamage(1) on all the gadgets also needs to be fixed, this is likely why we have the durability issue as well as needing to set the canRepair prop.
hvdklauw
force-pushed
the
552_fix_gadget_repairable
branch
2 times, most recently
from
ee5d626
to
214a39f
Compare
hvdklauw
changed the title
hvdklauw
changed the title
hvdklauw
force-pushed
the
552_fix_gadget_repairable
branch
from
214a39f
to
3c9776f
Compare
Also removed the damage as we use energy for durability.
hvdklauw
force-pushed
the
552_fix_gadget_repairable
branch
from
3c9776f
to
7062c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gadget should never be repairable, as it's powered.