Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LayoutRoot implementation of IXmlSerializable.ReadXml to read the end element. #88

Closed
Dirkster99 opened this issue Oct 31, 2019 · 0 comments
Closed

LayoutRoot implementation of IXmlSerializable.ReadXml to read the end element. #88

Dirkster99 opened this issue Oct 31, 2019 · 0 comments

Comments

@Dirkster99
Copy link
Owner

Implementations of IXmlSerializable.ReadXml are required to read the entire element from beginning to end, including all of its contents.

The current implementation would not read the end element from the reader. This cause issues if the LayoutRoot was being serialized as part of a parent object's xml serialization as the XmlReader would be left on an unexpected element.

xceedsoftware/wpftoolkit#1545
Dirkster99 added a commit that referenced this issue Oct 31, 2019
@Dirkster99
Implementations of IXmlSerializable.ReadXml are required to read the …
ffbe014 
…entire element from beginning to end, including all of its contents. Prior to this change it would not read the end element from the reader. This would cause issues if the LayoutRoot was being serialized as part of a parent object's xml serialization as the XmlReader would be left on an unexpected element.

#88
@Dirkster99 Dirkster99 mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dirkster99